e2e: Change containerdisk from cirros to alpine #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cirros image is not supported on s390x, use alpine instead. Signed-off-by: Jan Schintag <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
oshoval
approved these changes
Dec 1, 2024
|
Thanks /approve will ask someone to review as well |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@qinqon |
|
@0xFelix |
0xFelix
approved these changes
Dec 3, 2024
| @@ -83,7 +83,7 @@ func addNoCloudDiskWitUserData(spec *v1.VirtualMachineInstanceSpec, data string) | |||
| func CreateVmiObject(name string, namespace string, interfaces []v1.Interface, networks []v1.Network) *v1.VirtualMachineInstance { | |||
| vmi := getBaseVMI(randName(name)) | |||
| vmi.Namespace = namespace | |||
| addContainerDisk(&vmi.Spec, "quay.io/kubevirt/cirros-container-disk-demo:devel") | |||
| addContainerDisk(&vmi.Spec, "quay.io/kubevirt/alpine-container-disk-demo:v1.4.0") | |||
There was a problem hiding this comment.
Maybe we should invest in some effort to update the devel/latest tags automatically.
But for the time being:
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cirros image is not supported on s390x, use alpine instead.
What this PR does / why we need it:
Cirros is not built for s390x. Changing it to alpine ensures the e2e test can be run on s390x.
Special notes for your reviewer: